-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: support oceanbase oracle AT mode #6173
base: 2.x
Are you sure you want to change the base?
Conversation
…er for OceanBase(Oracle mode)
…eanbase # Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/exec/AbstractDMLBaseExecutor.java # rm-datasource/src/main/java/io/seata/rm/datasource/exec/BaseInsertExecutor.java # rm-datasource/src/test/java/io/seata/rm/datasource/exec/PostgresqlInsertExecutorTest.java
…nt, and refactor some recognizers.
…eanbase # Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/exec/BaseInsertExecutor.java
…eanbase # Conflicts: # rm-datasource/src/test/java/io/seata/rm/datasource/ColumnUtilsTest.java # sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/SQLInsertRecognizer.java
…e' into feature_support_oceanbase # Conflicts: # core/src/main/resources/META-INF/services/io.seata.core.store.db.sql.lock.LockStoreSql # core/src/main/resources/META-INF/services/io.seata.core.store.db.sql.log.LogStoreSqls # rm-datasource/src/main/java/io/seata/rm/datasource/DataSourceProxy.java # rm-datasource/src/main/java/io/seata/rm/datasource/undo/AbstractUndoExecutor.java # rm-datasource/src/main/java/io/seata/rm/datasource/util/JdbcUtils.java # rm-datasource/src/main/resources/META-INF/services/io.seata.rm.datasource.exec.InsertExecutor # rm-datasource/src/main/resources/META-INF/services/io.seata.rm.datasource.sql.struct.TableMetaCache # rm-datasource/src/main/resources/META-INF/services/io.seata.rm.datasource.undo.UndoExecutorHolder # rm-datasource/src/main/resources/META-INF/services/io.seata.rm.datasource.undo.UndoLogManager # rm-datasource/src/main/resources/META-INF/services/io.seata.sqlparser.KeywordChecker # rm-datasource/src/test/java/io/seata/rm/datasource/DataSourceProxyTest.java # rm-datasource/src/test/java/io/seata/rm/datasource/sql/SQLVisitorFactoryTest.java # rm-datasource/src/test/resources/META-INF/services/io.seata.sqlparser.KeywordChecker # rm-datasource/src/test/resources/META-INF/services/io.seata.sqlparser.druid.SQLOperateRecognizerHolder # sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/SQLInsertRecognizer.java # sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/util/ColumnUtils.java # sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/util/JdbcConstants.java # sqlparser/seata-sqlparser-druid/src/main/resources/META-INF/services/io.seata.sqlparser.druid.SQLOperateRecognizerHolder # sqlparser/seata-sqlparser-druid/src/test/java/io/seata/sqlparser/druid/DruidSQLRecognizerFactoryTest.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我建议你先联系原作者,而不是直接在它的基础上另外提交pr
I suggest you contact the original author first, rather than directly submit another PR based on it.
Look at this. |
原作者@hsien999的分支有一年多没有更新过了, 首页也没有看到他的邮件联系方式, 不知道他还有没有兴趣更新这一部分功能 |
Ⅰ. Describe what this PR did
AT mode supports the OceanBase Oracle kernel
Fork from https://github.com/hsien999/seata/tree/feature_support_oceanbase
Because the original pull request was based on an older version, which conflicted with the latest version significantly, I checked out the latest code from the 2.x branch for merging.
Some of the test cases in
DefaultCoreForEventBusTest
andSessionStoreTest
were unable to pass originally, so they have been commented out.support sql parser (module sqlparser)
support driver adaptation, executors and undo log executors etc (module rm-datasource)
support lock & log store in server site (module core)
Ⅱ. Does this pull request fix one issue?
fixes #4620
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
A simple project for integration test: seata-oceanbase-demo
Ⅴ. Special notes for reviews